Re: git: uh-oh
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Max Bowsher <maxb@f2s.com>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-09-06T04:09:46Z
Lists: pgsql-hackers
Michael Haggerty <mhagger@alum.mit.edu> writes: > Tom Lane wrote: >> I suspect what it's doing is attributing the branch creation to the user >> who makes the first commit on the branch for that file. In general I'd >> expect that to give a reasonable result --- better than choosing a >> guaranteed-to-be-wrong constant value anyway ;-) > On the contrary, I prefer an obvious indication of "I don't know" to a > value that might appear to be authoritative but is really just a guess. > It could be that one user copied the file verbatim to the branch and a > second user changed the file as part of an unrelated change. Hm, I see. > The "default default" value for these commits is "cvs2svn" (in your case > "cvs2git would probably be more appropriate), which I like because it > makes it clearer than "pgsql" that the commit was generated as part of a > conversion. If we can set it to a value different from any actual committer name, that would be a good thing to do. regards, tom lane