Horton

Re: Question about StartLogicalReplication() error path

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: robertmhaas@gmail.com, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org, andres@anarazel.de
Date: 2021-06-16T22:55:46Z
Lists: pgsql-hackers

Attachments

On Tue, 2021-06-15 at 15:19 +0900, Kyotaro Horiguchi wrote:
> I don't think the message is neded, but I don't oppose it as far as
> the level is LOG and the messages were changed as something like
> this:
> 
> 
> -               elog(DEBUG1, "cannot stream from %X/%X, minimum is
> %X/%X, forwarding",
> +               elog(LOG, "%X/%X has been already streamed,
> forwarding to %X/%X",
> 
> FWIW, I most prefer #1. I see #2 as optional. and see #3 as the
> above.

Attached.

Regards,
	Jeff Davis

Commits

  1. Improve documentation for START_REPLICATION ... LOGICAL.