Re: role self-revocation

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Stephen Frost <sfrost@snowman.net>, Joshua Brindle <joshua.brindle@crunchydata.com>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2022-03-08T04:14:31Z

Lists: pgsql-hackers

Attachments

v1-0001-WIP-Removing-role-self-administration.patch.WIP (application/octet-stream)
(unnamed) (text/plain)

> On Mar 7, 2022, at 12:16 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> What would be
> lost if we drop it?

I looked into this a bit.  Removing that bit of code, the only regression test changes for "check-world" are the expected ones, with nothing else breaking.  Running installcheck+pg_upgrade to the patched version of HEAD from each of versions 11, 12, 13 and 14 doesn't turn up anything untoward.  The change I used (for reference) is attached:

Commits

Make role grant system more consistent with other privileges.
- ce6b672e4455 16.0 landed
Ensure that pg_auth_members.grantor is always valid.
- 6566133c5f52 16.0 landed
Remove the ability of a role to administer itself.
- 79de9842ab03 15.0 landed
Add tests of the CREATEROLE attribute
- e9d4001ec592 15.0 landed
Replace explicit PIN entries in pg_depend with an OID range test.
- a49d08123599 15.0 cited
Shore up ADMIN OPTION restrictions.
- fea164a72a7b 9.4.0 cited
Add pg_has_role() family of privilege inquiry functions modeled after the
- f9fd1764615e 8.1.0 cited
Align GRANT/REVOKE behavior more closely with the SQL spec, per discussion
- 4b2dafcc0b1a 8.0.0 cited