Horton

Re: contrib modules and relkind check

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-09T03:02:10Z
Lists: pgsql-hackers

Attachments

On 2017/03/09 11:51, Michael Paquier wrote:
> On Wed, Mar 8, 2017 at 5:10 PM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> On 2017/03/08 16:47, Michael Paquier wrote:
>>> Only regular tables are tested as valid objects. Testing toast tables
>>> is not worth the complication. Could you add as well a matview?
>>
>> Done in the attached updated patch.
> 
> +select count(*) > 0 from pg_visibility('matview');
> + ?column?
> +----------
> + f
> +(1 row)
> That's quite a generic name :) You may want to use less common names
> in your tests.

I agree.  Updated patch attached.

> 
> OK, I am marking that as ready for committer.

Thanks.

Regards,
Amit

Commits

  1. Add relkind checks to certain contrib modules