Re: Terminate the idle sessions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Li Japin <japinli@hotmail.com>,
"David G. Johnston" <david.g.johnston@gmail.com>,
"kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
"bharath.rupireddyforpostgres@gmail.com"
<bharath.rupireddyforpostgres@gmail.com>,
"pgsql-hackers@lists.postgresql.org"
<pgsql-hackers@lists.postgresql.org>
Date: 2021-01-10T20:58:56Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes: > On Thu, Jan 7, 2021 at 4:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Thomas Munro <thomas.munro@gmail.com> writes: >>> One of the strange things about these errors is that they're >>> asynchronous/unsolicited, but they appear to the client to be the >>> response to their next request (if it doesn't eat ECONNRESET instead). >> Right, which is what makes class 57 (operator intervention) seem >> attractive to me. From the client's standpoint these look little >> different from ERRCODE_ADMIN_SHUTDOWN or ERRCODE_CRASH_SHUTDOWN, >> which are in that category. > Yeah, that's a good argument. Given the lack of commentary on this thread, I'm guessing that people aren't so excited about this topic that a change in the existing sqlstate assignment for ERRCODE_IDLE_IN_TRANSACTION_SESSION_TIMEOUT would fly. So I propose to change the new ERRCODE_IDLE_SESSION_TIMEOUT to be in class 57 and call it good. regards, tom lane
Commits
-
Rethink SQLSTATE code for ERRCODE_IDLE_SESSION_TIMEOUT.
- 4edf96846a02 14.0 landed
-
Improve commentary in timeout.c.
- 9486e7b666fd 14.0 landed
-
Add idle_session_timeout.
- 9877374bef76 14.0 landed
-
Improve timeout.c's handling of repeated timeout set/cancel.
- 09cf1d522676 14.0 landed