Re: Improve pgindent's formatting named fields in struct literals and varidic functions

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>
To: Tom Lane <tgl@sss.pgh.pa.us>, Álvaro Herrera <alvherre@kurilemu.de>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-04-12T21:06:24Z
Lists: pgsql-hackers

Attachments

On 3/31/26 8:57 PM, Andreas Karlsson wrote:
> On 3/31/26 8:13 PM, Tom Lane wrote:
>> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
>>> I think the best time to get it in is a few weeks after the feature
>>> freeze.  That way we minimize the impact on any fixes during the
>>> stabilization period.  I'm not sure at what point relative to the betas
>>> though; is it better to do it before, so that we have a chance to fix
>>> any possible problems before they hit users, or is it better to do after
>>> beta1, so that patches that we discover need reverting for pg19 have
>>> already had a chance to be so?
>>
>> [...]
>>
>> So we haven't been totally consistent about it, but mid-May (a couple
>> weeks before making the new branch) seems like the usual choice.
> Makes sense to merge it while the tree is less noisy. Especially right 
> now might be the most annoying time possible.
Rebased patch on top of HEAD.

Andreas

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Make pg_bsd_indent add a space between comma and period.