Re: A bug in mapping attributes in ATExecAttachPartition()

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Amit Langote <amitlangote09@gmail.com>

Date: 2017-07-12T01:47:24Z

Lists: pgsql-hackers

Attachments

0001-Cope-with-differing-attnos-in-ATExecAttachPartition-.patch (text/plain) patch 0001
0002-Teach-ATExecAttachPartition-to-skip-validation-in-mo.patch (text/plain) patch 0002

On 2017/07/11 19:49, Ashutosh Bapat wrote:
> On Tue, Jul 4, 2017 at 9:51 AM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> 
>>
>> Attached updated patches.
> 
> There's an extra "we" in
> +        * Note that attachRel's OID is in this list.  If it's partitioned, we
> +        * we don't need to schedule it to be scanned (would be a noop anyway
> 
> And some portions of the comment before find_all_inheritors() in
> ATExecAttachPartition() look duplicated in portions of the code that
> check constraints on the table being attached and each of its leaf
> partition.
> 
> Other than that the patches look good to me.

Thanks for the review.  Patch updated taking care of the comments.

Regards,
Amit

Commits

Fix inconsistent capitalization.
- 29f021160ea7 10.0 landed
- 42651bdd68a1 11.0 landed
Fix bug in deciding whether to scan newly-attached partition.
- f85f88bcc270 10.0 landed
Fix lock upgrade hazard in ATExecAttachPartition.
- 972b6ec20bf0 10.0 landed
Code beautification for ATExecAttachPartition.
- 583df3b5c562 10.0 landed
Teach predtest.c about CHECK clauses to fix partitioning bugs.
- b08df9cab777 10.0 landed
Don't explicitly mark range partitioning columns NOT NULL.
- 3ec76ff1f2cf 10.0 cited