Horton

Re: Improve error handling of HMAC computations and SCRAM

Sergey Shinderuk <s.shinderuk@postgrespro.ru>

View thread View on postgr.es
From: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-11T08:08:59Z
Lists: pgsql-hackers 
On 11.01.2022 10:57, Michael Paquier wrote:
> On Tue, Jan 11, 2022 at 10:50:50AM +0300, Sergey Shinderuk wrote:
>> + * Returns a static string providing errors about an error that happened
>>
>> "errors about an error" looks odd.
> 
> Sure, that could be reworded.  What about "providing details about an
> error"?

Yeah, that's better.  I thought "providing errors about an error" was a 
typo, but now I see the same comment was committed in b69aba745.  Is it 
just me? :)

Thanks,

-- 
Sergey Shinderuk		https://postgrespro.com/

Commits

  1. Improve error handling of HMAC computations

  2. Fix incorrect comments in hmac.c and hmac_openssl.c

  3. Fix comment related to pg_cryptohash_error()