Horton

Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Teodor Sigaev <teodor@sigaev.ru>

View thread View on postgr.es
From: Teodor Sigaev <teodor@sigaev.ru>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>, Robert Haas <robertmhaas@gmail.com>
Cc: Jan Przemysław Wójcik <jan.przemyslaw.wojcik@gmail.com>, Postgres-Bugs <pgsql-bugs@postgresql.org>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-12-12T11:21:06Z
Lists: pgsql-bugs, pgsql-hackers 
> 0002-pg-trgm-strict_word-similarity.patch – implementation of 
> strict_word_similarity() with comments, docs and tests.

The patch looks commmitable, but sometime I get
*** ...pgsql/contrib/pg_trgm/expected/pg_strict_word_trgm.out 2017-12-12 
14:16:55.190989000 +0300
--- .../pgsql/contrib/pg_trgm/results/pg_strict_word_trgm.out  2017-12-12 
14:17:27.645639000 +0300
***************
*** 153,160 ****
   ----------+----------------------------------
           0 | Kabankala
        0.25 | Kabankalan City Public Plaza
-  0.416667 | Kabakala
    0.416667 | Abankala
    0.538462 | Kabikala
       0.625 | Ntombankala School
    0.642857 | Nehalla Bankalah Reserved Forest
--- 153,160 ----
   ----------+----------------------------------
           0 | Kabankala
        0.25 | Kabankalan City Public Plaza
    0.416667 | Abankala
+  0.416667 | Kabakala
    0.538462 | Kabikala
       0.625 | Ntombankala School
    0.642857 | Nehalla Bankalah Reserved Forest

======================================================================


Seems, some stability order should be added to tests

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Commits

  1. Update trigram example in docs to correct state

  2. Add strict_word_similarity to pg_trgm module

  3. Rework word_similarity documentation, make it close to actual algorithm.