Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
David E. Wheeler <david@kineticode.com>
From: "David E. Wheeler" <david@kineticode.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Fetter <david@fetter.org>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2010-02-19T00:36:07Z
Lists: pgsql-hackers
On Feb 18, 2010, at 3:27 PM, Tom Lane wrote: >> While hacking on PL/Parrot, I ran across an issue where when trying to >> load PL/pgsql, it's done unconditionally and fails. How do we fix >> pg_regress to be a little more subtle about this? > > Why exactly would we want it to not fail? Regression tests are not > about papering over problems. pg_regress needs to not install plpgsql into the data database on 9.0 when passed `--load-language=plpgsql`, because plpgsql will of course already be installed. Unless you want all the third-party modules that depend on plpgsql for tests to somehow detect that they're going to run on 8.5a3 or later and not pass that option. But that'd be kind of a PITA. Much easier if pg_regress knows it doesn't need to install plpgsql. Best, David