Re: Importing pg_bsd_indent into our source tree

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-02-11T23:54:00Z
Lists: pgsql-hackers

Attachments

Here's a v3 of this patchset, incorporating your meson fixes as
well as patches for the portability problems you noted.

I ended up converting the test infrastructure into a TAP test,
which kind of feels like overkill; but the Meson system doesn't
seem to provide any lower-overhead way to run a test.

I've not touched the issue of whether and where to install
pg_bsd_indent; for now, neither build system will do so.

Also, for now both build systems *will* run tests on it,
although I'm not sure if plugging it into "make check-world"
is enough to cause the cfbot to do so, and I'm pretty sure
that the buildfarm won't notice that.

I'll let the cfbot loose on this, and if it runs the tests
successfully I plan to go ahead and push.  We can resolve
the installation question later.  We might want to back off
testing too once we're satisfied about portability.

(I left out the 0004 declaration-formatting patch for now, btw.)

			regards, tom lane

Commits

  1. Integrate pg_bsd_indent into our build/test infrastructure.

  2. Sync pg_bsd_indent's copyright notices with Postgres practice.

  3. Import pg_bsd_indent sources.