Horton

Re: [PATCH] Add regression tests of ecpg command notice (error / warning)

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Ryo Kanbayashi <kanbayashi.dev@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-03-03T03:23:56Z
Lists: pgsql-hackers

Attachments


On 2025/03/01 19:45, Ryo Kanbayashi wrote:
>> +program_help_ok('ecpg');
>> +program_version_ok('ecpg');
>> +program_options_handling_ok('ecpg');
>> +command_fails(['ecpg'], 'ecpg without arguments fails');
>>
>> These checks seem unnecessary in 002 since they're already covered in 001.
> 
> I reflected above.

Thanks for updating the patch!

I've made some minor fixes and cosmetic adjustments.
The updated patch is attached.

Unless there are any objections, I'll commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. ecpg: Fix compiler warning in ecpg build with Meson.

  2. ecpg: Add TAP test for the ecpg command.

  3. Avoid updating inactive_since for invalid replication slots.