Horton

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Stephen Frost <sfrost@snowman.net>, Heikki Linnakangas <hlinnaka@iki.fi>, Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-27T20:19:22Z
Lists: pgsql-hackers 
> On 27 Jan 2018, at 00:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> I've pushed this mostly as-is.  

Thanks!

> I also took out the parser changes related to
> allowing unquoted PARALLEL in old-style CREATE AGGREGATE, because that
> is not a goal I consider worthy of adding extra grammar complexity.
> We don't document that PARALLEL works there, and there has never been
> any expectation that deprecated legacy syntax would grow new options
> as needed to have feature parity with the modern syntax.

Ok, didn’t know old syntax wasn’t extended to support new options so I went
after it having run into the regress tests using it.

> I also trimmed the new regression test cases a bit, as most of them seemed
> pretty duplicative.

Makes sense, they were made verbose to aid review but were too chatty for
inclusion.

cheers ./daniel

Commits

  1. Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers.