Re: IPC/MultixactCreation on the Standby server
Andrey Borodin <x4mmm@yandex-team.ru>
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers@lists.postgresql.org, Ivan Bykov <i.bykov@modernsys.ru>, Kirill Reshke <reshkekirill@gmail.com>
Date: 2025-12-05T18:36:42Z
Lists: pgsql-hackers
> On 5 Dec 2025, at 21:36, Maxim Orlov <orlovmg@gmail.com> wrote:
>
> It's good that the test was added. But it seems like it could be
> improved a bit. The problem is, it only runs successfully with a
> standard block size. Plus, the comment about the number of bytes was a
> bit unclear, for my taste. PFA patch, it should make this test pass
> with different block sizes.
Oh, great catch!
Other tests seem to extract block size using database query like
$primary->safe_psql('postgres',
"SELECT setting::int FROM pg_settings WHERE name = 'block_size';");
or
$blksize = int($node->safe_psql('postgres', 'SHOW block_size;'));
But here we do not have running cluster, so resorting to parsing pg_resetwal seems reasonable.
Thanks!
Best regards, Andrey Borodin.