Horton
Menu

Re: peripatus build failures....

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Larry Rosenman <ler@lerctr.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-06T23:18:46Z
Lists: pgsql-hackers 
Larry Rosenman <ler@lerctr.org> writes:
> On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
>> I do not like the "-Wl,-z,notext" thing at all.  It fails to explain
>> why things are working OK in v11/HEAD, which makes me think that it's
>> band-aiding something rather than really fixing it.

> Following the advice in the error message, the following ALSO fixes it
> (REL_10_STABLE):
> +override CFLAGS   := -fPIC

Yeah, I wondered about whether that wasn't a cleaner answer, but the same
problem remains: if we need that in src/port/, why don't all the branches
need it?  It would be unsurprising if we'd gained a requirement for -fPIC
somewhere along the line, but I don't entirely believe that we lost one.
So I'd still like to know when this changed.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent accidental linking of system-supplied copies of libpq.so etc.

  2. Fix partial-build problems introduced by having more generated headers.

  3. Fix the new ARMv8 CRC code for short and unaligned input.

  4. Use ARMv8 CRC instructions where available.

  5. Fix incorrect description of USE_SLICING_BY_8_CRC32C.

  6. Add an assertion that we don't pass NULL to snprintf("%s").

  7. Update copyright for 2018