Horton

Re: [PATCH] pg_convert improvement

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Yurii Rashkovskii <yrashk@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-11-28T06:45:28Z
Lists: pgsql-hackers 
Hi,

On 11/28/23 2:16 AM, Yurii Rashkovskii wrote:
>   Hi Bertrand,
> 
> 
>     Did some minor changes in the attached:
> 
>     - Started the multi-line comment with an upper case and finished
>     it with a "." and re-worded a bit.
>     - Ran pgindent
> 
>     What do you think about the attached?
> 
> 
> It looks great!
> 
> 
>     Also, might be good to create a CF entry [1] so that the patch proposal does not get lost
>     and gets visibility.
> 
> 
> Just submitted it to SF. Thank you for the review!
> 

Thanks! Just marked it as "Ready for Committer".

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Teach convert() and friends to avoid copying when possible.