Re: SQLSTATE for replication connection failures

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-16T15:53:50Z
Lists: pgsql-hackers
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> On Mon, Jun 14, 2021 at 6:18 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> Shall we just use ERRCODE_CONNECTION_FAILURE for these failures, or
>>> would it be better to invent another SQLSTATE code?  Arguably,
>>> ERRCODE_CONNECTION_FAILURE is meant for failures of client connections;
>>> but on the other hand, a replication connection is a sort of client.

>> Your reasoning sounds good to me. So, +1 for using ERRCODE_CONNECTION_FAILURE.

> +1

Done that way.  I also fixed some nearby ereports that were missing
errcodes; some of them seemed more like PROTOCOL_VIOLATIONs than
CONNECTION_FAILUREs, though.

			regards, tom lane



Commits

  1. Improve SQLSTATE reporting in some replication-related code.