Horton

Re: ECPG cleanup and fix for clang compile-time problem

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: John Naylor <johncnaylorls@gmail.com>, pgsql-hackers@lists.postgresql.org, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>
Date: 2024-10-04T20:46:44Z
Lists: pgsql-hackers

Attachments

I wrote:
> The cfbot points out that I should probably have marked progname
> as "static" in 0008.  I'm not going to repost the patchset just for
> that, though.

Rebase needed after f22e84df1, so here's an update that rebases
up to HEAD and adds the missing "static".  No other changes.

(Anybody want to review this?  I'm getting tired of rebasing it,
and we're missing out on the clang build time savings.)

			regards, tom lane

Commits

  1. ecpg: clean up some other assorted memory leaks.

  2. ecpg: fix some memory leakage of data-type-related structures.

  3. ecpg: put all string-valued tokens returned by pgc.l in local storage.

  4. ecpg: fix more minor mishandling of bad input in preprocessor.

  5. ecpg: fix some minor mishandling of bad input in preprocessor.

  6. ecpg: avoid breaking the IDENT precedence level in two.

  7. ecpg: improve preprocessor's memory management.

  8. ecpg: move some functions into a new file ecpg/preproc/util.c.

  9. ecpg: re-implement preprocessor's string management.

  10. ecpg: major cleanup, simplification, and documentation of parse.pl.

  11. ecpg: remove check_rules.pl.

  12. ecpg: clean up documentation of parse.pl, and add more input checking.

  13. Clean up indentation and whitespace inconsistencies in ecpg.

  14. Exclude flex-generated code from coverage testing