Re: new heapcheck contrib module

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-02-02T23:10:34Z

Lists: pgsql-hackers

Attachments

v36-0001-Refactoring-processSQLNamePattern.patch (application/octet-stream) patch v36-0001
v36-0002-Moving-code-from-src-bin-scripts-to-fe_utils.patch (application/octet-stream) patch v36-0002
v36-0003-Parameterizing-parallel-slot-result-handling.patch (application/octet-stream) patch v36-0003
v36-0004-Adding-contrib-module-pg_amcheck.patch (application/octet-stream) patch v36-0004
v36-0005-Extending-PostgresNode-to-test-corruption.patch (application/octet-stream) patch v36-0005
(unnamed) (text/plain)


> On Jan 31, 2021, at 4:05 PM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
> 
> Attached is patch set 35.

I found some things to improve in the v35 patch set.  Please find attached the v36 patch set, which differs from v35 in the following ways:

0001 -- no changes

0002 -- fixing omissions in @pgfeutilsfiles in file src/tools/msvc/Mkvcbuild.pm

0003 -- no changes

0004:
  -- Fixes handling of amcheck contrib module installed in non-default schema.
  -- Adds database name to corruption messages to make identifying the relation being complained about unambiguous in multi-database checks
  -- Fixes an instance where pg_amcheck was querying pg_database without schema-qualifying it
  -- Simplifying some functions in pg_amcheck.c
  -- Updating a comment to reflect the renaming of a variable that the comment mentioned by name

0005 -- fixes =pod added in PostgresNode.pm.  The =pod was grammatically correct so far I can tell, but rendered strangely in perldoc.

Commits

Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Generalize parallel slot result handling.
- 418611c84d00 14.0 landed
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
- e955bd4b6c2b 14.0 landed
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 landed
Doc: clean up verify_heapam() documentation.
- 4c49d8fc15ee 14.0 landed
Fix more portability issues in new amcheck code.
- 321633e17b07 14.0 landed
Fix portability issues in new amcheck test.
- 860593ec3bd1 14.0 landed
Try to avoid a compiler warning about using fxid uninitialized.
- 8bb0c9770e80 14.0 landed
Extend amcheck to check heap pages.
- 866e24d47db1 14.0 landed
Adjust walsender usage of xlogreader, simplify APIs
- 850196b610d2 13.0 cited
Improve checking of child pages in contrib/amcheck.
- d114cc538715 13.0 cited
Sanitize line pointers within contrib/amcheck.
- a9ce839a3137 12.0 cited
Fix possible sorting error when aborting use of abbreviated keys.
- 008c4135ccf6 10.0 cited