Re: implicit declaration of datumIsEqual in parse_coerce.c

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2020-04-08T02:39:30Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote:
>> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably
>> explains why most of us aren't seeing it.  My guess is somebody
>> removed an #include without realizing that this chunk of code
>> needed it.

> [cough]

Bleagh.  Either of you want to put it back?  (Maybe with a comment
this time, like "needed for datumIsEqual()".)

Curiously, there are no buildfarm warnings about this, even though we have
at least one member running with RANDOMIZE_ALLOCATED_MEMORY.  Wonder why?

			regards, tom lane



Commits

  1. Put back mistakenly removed #include.

  2. Restructure polymorphic-type resolution in funcapi.c.