Horton

Re: [PoC] Federated Authn/z with OAUTHBEARER

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Wolfgang Walther <walther@technowledgy.de>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>, Jelte Fennema-Nio <postgres@jeltef.nl>, Christoph Berg <myon@debian.org>, Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Thomas Munro <thomas.munro@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Antonin Houska <ah@cybertec.at>
Date: 2025-04-14T16:42:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. meson: Fix install-quiet after clean

  2. oauth: Run Autoconf tests with correct compiler flags

  3. Link libpq with libdl if the platform needs that.

  4. Doc: correct spelling of meson switch.

  5. oauth: Correct SSL dependency for libpq-oauth.a

  6. oauth: Fix Autoconf build on macOS

  7. oauth: Move the builtin flow into a separate module

  8. Remove a stray "pgrminclude" annotation

  9. oauth: Simplify copy of PGoauthBearerRequest

  10. oauth: Improve validator docs on interruptibility

  11. oauth: Disallow synchronous DNS in libcurl

  12. oauth: Fix postcondition for set_timer on macOS

  13. oauth: Use IPv4-only issuer in oauth_validator tests

  14. Work around OAuth/EVFILT_TIMER quirk on NetBSD.

  15. oauth: Fix incorrect const markers in struct

  16. Add missing entry to oauth_validator test .gitignore

  17. cirrus: Temporarily fix libcurl link error

  18. Add support for OAUTHBEARER SASL mechanism

  19. libpq: Handle asynchronous actions during SASL

  20. require_auth: prepare for multiple SASL mechanisms

  21. Move PG_MAX_AUTH_TOKEN_LENGTH to libpq/auth.h

  22. Make SASL max message length configurable

  23. jsonapi: fully initialize dummy lexer

  24. common/jsonapi: support libpq as a client

  25. Remove fe_memutils from libpgcommon_shlib

  26. Revert ECPG's use of pnstrdup()

  27. Explicitly require password for SCRAM exchange

  28. Refactor SASL exchange to return tri-state status

Hi,

On 2025-04-11 18:21:14 +0200, Wolfgang Walther wrote:
> Jacob Champion:
> > On Wed, Apr 9, 2025 at 4:42 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
> > > I think your suggestion of not using any .so files would best there (from w user perspective). I'd be quite surprised if a static build still resulted in me having to manage shared library files anyway.
> > Done this way in v5. I had planned to separate the implementations by
> > a #define, but I ran into issues with Makefile.shlib, so I split the
> > shared and dynamic versions into separate files. I just now realized
> > that we do something about this exact problem in src/common, so I'll
> > see if I can copy its technique for the next go round.
> 
> I tried to apply this patch to nixpkgs' libpq build [1]. First, I pinned a
> recent commit from master (one where the v5 patch will apply cleanly later)
> and enabled --with-libcurl [2].
> 
> At this stage, without the patch applied, I observe the following:
> 
> 1. The default, dynamically linked, build succeeds and libpq.so is linked to
> libcurl.so as expected!
> 
> 2. The statically linked build fails during configure:

What specifically does "statically linked build" mean? There is no such thing
in postgres, so this must be either patching upstream or injecting build flags
somehow?  The [1] link wasn't immediately elucidating.


>   checking for curl_multi_init in -lcurl... no
>   configure: error: library 'curl' does not provide curl_multi_init
> 
> config.log tells me that it can't link to libcurl, because of undefined
> references, for example:
> 
>   undefined reference to `psl_is_cookie_domain_acceptable'
>   undefined reference to `nghttp2_session_check_request_allowed'
> 
> I assume the many libs listed in Libs.private in libcurl.pc are not added
> automatically for this check?

The configure test shouldn't link statically, so this doesn't make sense to
me?

Greetings,

Andres Freund