Re: NOT NULL constraints on range partition key columns
Amit Langote <langote_amit_f8@lab.ntt.co.jp>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-16T09:56:30Z
Lists: pgsql-hackers
Attachments
On 2017/05/16 4:29, Robert Haas wrote: > On Mon, May 15, 2017 at 9:12 AM, Amit Kapila <amit.kapila16@gmail.com> wrote: >> Can't we allow NULL to get inserted into the partition (leaf >> partition) if the user uses the partition name in Insert statement? > > That would be terrible behavior - the behavior of tuple routing should > match the enforced constraints. > >> For root partitions, I think for now giving an error is okay, but once >> we have default partitions (Rahila's patch), we can route NULLS to >> default partition. > > Yeah, that's exactly why I think we should make the change Amit is > proposing here. If we don't, then we won't be able to accept NULL > values even after we have the default partitioning stuff. Attached is a patch for consideration. There are 2 actually, but maybe they should be committed together if we decide do go with this. Thanks, Amit
Commits
-
Don't explicitly mark range partitioning columns NOT NULL.
- 3ec76ff1f2cf 10.0 landed