Horton
Menu

Re: Inconsistent trigger behavior between two temporal leftovers

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>, Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Sergei Patiakin <sergei.patiakin@enterprisedb.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-06-04T09:18:24Z
Lists: pgsql-hackers 
On 05.05.26 23:48, Paul A Jungwirth wrote:
> On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>>
>> + /*
>> + * Re-copy the original row into leftoverSlot because
>> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
>> + * triggers, which can modify the slot contents.
>> + */
>>
>> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
>> comments/commit message/test is specific about this.
> 
> I agree being specific is helpful. Here is an updated patch.

committed

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix cross-leftover pollution in FOR PORTION OF insert triggers