Horton

Re: ECPG Refactor: move sqlca variable in ecpg_log()

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Yuto Sasaki (Fujitsu)" <sasaki.yuto-00@fujitsu.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-21T14:25:18Z
Lists: pgsql-hackers

Attachments


On 2024/10/19 2:43, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> I've attached the latest version of the patch, now including the commit log.
>> Unless there are any objections, I'll proceed with committing it.
> 
> LGTM.  Maybe move down the sqlca variable declaration, so that the
> declarations still match the order in which the variables are
> initialized?  That's just cosmetic of course.

Thanks for the review! I've updated the patch accordingly, i.e.,
moved the declaration of the sqlca variable right after fmt.
The v3 patch is attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. ecpg: Refactor ecpg_log() to skip unnecessary calls to ECPGget_sqlca().