Re: Minimal logical decoding on standbys

bdrouvotAWS <bdrouvot@amazon.com>

From: "Drouvot, Bertrand" <bdrouvot@amazon.com>

To: <fabriziomello@gmail.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, tushar <tushar.ahuja@enterprisedb.com>, "[pgdg] Robert Haas" <robertmhaas@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-03-18T08:33:45Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Reduce the log level in 035_standby_logical_decoding.pl.
- 3034dc56ef4b 16.0 landed
035_standby_logical_decoding: Add missing waits for replication
- 57411c82ce86 16.0 landed
For cascading replication, wake physical and logical walsenders separately
- e101dfac3a53 16.0 landed
Handle logical slot conflicts on standby
- 26669757b6a7 16.0 landed
Support invalidating replication slots due to horizon and wal_level
- be87200efd93 16.0 landed
Prevent use of invalidated logical slot in CreateDecodingContext()
- 4397abd0a2af 16.0 landed
Replace replication slot's invalidated_at LSN with an enum
- 15f8203a5975 16.0 landed
Pass down table relation into more index relation functions
- 61b313e47eb9 16.0 landed
Assert only valid flag bits are passed to visibilitymap_set()
- a88a18b1250b 16.0 landed
Remove unused _bt_delitems_delete() argument.
- dc43492e46c7 14.0 cited
Add xl_btree_delete optimization.
- d2e5e20e5711 13.0 cited

Attachments

v10-0005-Doc-changes-describing-details-about-logical-dec.patch (text/plain) patch v10-0005
v10-0004-New-TAP-test-for-logical-decoding-on-standby.patch (text/plain) patch v10-0004
v10-0003-Handle-logical-slot-conflicts-on-standby.patch (text/plain) patch v10-0003
v10-0002-Add-info-in-WAL-records-in-preparation-for-logic.patch (text/plain) patch v10-0002
v10-0001-Allow-logical-decoding-on-standby.patch (text/plain) patch v10-0001

Hi,

On 2/4/21 6:33 PM, Fabrízio de Royes Mello wrote:
>
> On Thu, Feb 4, 2021 at 1:49 PM Drouvot, Bertrand <bdrouvot@amazon.com 
> <mailto:bdrouvot@amazon.com>> wrote:
> >
> > Had to do a little change to make it compiling again (re-add the 
> heapRel argument in _bt_delitems_delete() that was removed by commit 
> dc43492e46c7145a476cb8ca6200fc8eefe673ef).
> >
> > Given that this attached v9 version:
> >
> > compiles successfully on current master
> > passes "make check"
> > passes the 2 associated tap tests "make -C src/test/recovery check 
> PROVE_TESTS=t/022_standby_logical_decoding_xmins.pl 
> <http://022_standby_logical_decoding_xmins.pl> PROVE_FLAGS=-v"  and 
> "make -C src/test/recovery check 
> PROVE_TESTS=t/023_standby_logical_decoding_conflicts.pl 
> <http://023_standby_logical_decoding_conflicts.pl> PROVE_FLAGS=-v"
> >
>
> Perfect thanks... will review ASAP!

Thanks!

Just made minor changes to make it compiling again on current master 
(mainly had to take care of ResolveRecoveryConflictWithSnapshotFullXid() 
that has been introduced in e5d8a99903).

Please find enclosed the new patch version that currently passes "make 
check" and the 2 associated TAP tests.

I'll have a look to the whole thread to check if there is anything else 
waiting in the pipe regarding this feature, unless some of you know off 
the top of their head?

Bertrand