Re: TM format can mix encodings in to_char()
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-04-21T13:25:48Z
Lists: pgsql-hackers
On 4/21/19 12:28 AM, Tom Lane wrote: > I wrote: >> [ fix-encoding-and-error-recovery-in-cache-locale-time.patch ] > On closer inspection, I'm pretty sure either version of this patch > will break things on Windows, because that platform already had code > to convert the result of wcsftime() to the database encoding; we > were adding code to do a second conversion, which will not go well. > > The attached revised patch deletes the no-longer-necessary > platform-specific recoding stanza, in favor of having cache_locale_time > know that it's getting UTF8 rather than something else. I also > updated a bunch of the related comments. > > I don't have any way to test this on Windows, so could somebody > do that? Manually running the Turkish test cases ought to be enough. > > How does one do that? Just set a Turkish locale? cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Repair assorted issues in locale data extraction.
- e899df6a24f6 11.3 landed
- c0bafc5e58c5 9.4.22 landed
- 7c02c3f75604 10.8 landed
- 74589026f79f 9.5.17 landed
- 1e5de96629f6 9.6.13 landed
- 7ad1cd31bfcb 12.0 landed