Horton

Re: pg_partition_tree crashes for a non-defined relation

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>, Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-13T06:34:56Z
Lists: pgsql-hackers 
On 2018/12/12 9:52, Michael Paquier wrote:
> On Mon, Dec 10, 2018 at 10:52:37PM +0900, Michael Paquier wrote:
>> OK.  Sure, let's do as you suggest then.  I'll wait a couple of days
>> before committing the patch so as if someone has extra comments they
>> have the time to post.  So please feel free to comment!
> 
> And done this way.  Thanks for the input, Stephen and others!

Thank you Michael for taking care of this.  I agree with the consensus
that instead of throwing an error for unsupported relkinds,
pg_partition_tree should rather return single row containing NULL for all
columns.

Regards,
Amit

Commits

  1. Test partition functions with legacy inheritance children, too

  2. Consider only relations part of partition trees in partition functions

  3. Make pg_partition_tree return no rows on unsupported and undefined objects

  4. Tweak pg_partition_tree for undefined relations and unsupported relkinds