Re: [PATCH] GROUP BY ALL

Vik Fearing <vik@postgresfriends.org>

From: Vik Fearing <vik@postgresfriends.org>

To: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>

Cc: David Christensen <david@pgguru.net>, Andrey Borodin <x4mmm@yandex-team.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, "David G. Johnston" <david.g.johnston@gmail.com>, Jelte Fennema-Nio <postgres@jeltef.nl>

Date: 2025-09-27T18:14:58Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add GROUP BY ALL.
- ef38a4d9756d 19 (unreleased) landed
Refactor to avoid code duplication in transformPLAssignStmt.
- b0fb2c6aa5a4 19 (unreleased) landed
Fix missed copying of groupDistinct in transformPLAssignStmt.
- b7f6798c056a 16.11 landed
- 9ca79896aba3 15.15 landed
- 78a284b0b8d4 18.1 landed
- 7504d2be9eb4 19 (unreleased) landed
- 3fc9aa5b0233 17.7 landed
- 0be39b4b1a01 14.20 landed

On 27/09/2025 18:03, Tom Lane wrote:
> So according to the standard, this:
>
> 	select a+b, count(*) from ... group by all;
>
> would be invalid because a+b couldn't be written directly in
> GROUP BY?

Correct.

> I can't see us rejecting that though, since we do
> allow a+b in GROUP BY.

No, nor do I.  Also, there were rumors about adding expressions to group 
by in the standard but no formal proposal yet.

FWIW, I opposed adding this GROUP BY ALL feature, but I was 
outnumbered.  I hope to never see it in production.

-- 

Vik Fearing