Re: Proposal for Updating CRC32C with AVX-512 Algorithm.
Matthew Sterrett <matthewsterrett2@gmail.com>
From: "Sterrett, Matthew" <matthewsterrett2@gmail.com>
To: "Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>,
Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Bruce Momjian <bruce@momjian.us>,
Alvaro Herrera <alvherre@alvh.no-ip.org>,
"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
"Shankaran, Akash" <akash.shankaran@intel.com>
Date: 2024-12-19T00:00:37Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Compute CRC32C using AVX-512 instructions where available
- 3c6e8c123896 18.0 landed
Attachments
- v10-0001-Add-a-Postgres-SQL-function-for-crc32c-benchmark.patch (text/plain) patch v10-0001
- v10-0002-Refactor-consolidate-x86-ISA-and-OS-runtime-chec.patch (text/plain) patch v10-0002
- v10-0003-Add-AVX-512-CRC32C-algorithm-with-a-runtime-chec.patch (text/plain) patch v10-0003
- v10-0004-Mark-pg_comp_crc32c-as-PGDLLIMPORT-for-Windows-b.patch (text/plain) patch v10-0004
On 12/7/2024 12:42 AM, Devulapalli, Raghuveer wrote: >> [0] https://cirrus-ci.com/task/6023394207989760 >> [1] https://cirrus-ci.com/task/5460444254568448 >> [2] https://cirrus-ci.com/task/6586344161411072 > > I was able to fix [0] and [1], but I can't think of why [2] fails. When I tried to reproduce this locally, I get a different unrelated error. Any idea why I am seeing this? > > LINK : fatal error LNK1181: cannot open input file 'C:\Program Files\Git\nologo' > > Commands: meson setup build && cd build && meson compile Hello! I'm Matthew Sterrett and I'm a coworker of Raghuveer; he asked me to look into the Windows build failures related to pg_comp_crc32c. It seems that the only thing that was required to fix that is to mark pg_comp_crc32c as PGDLLIMPORT, so I added a patch that does just that. I'm new to working with mailing lists, so please tell me if I messed anything up! Matthew Sterrett