Re: Why is src/test/modules/committs/t/002_standby.pl flaky?
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-01-13T07:00:00Z
Lists: pgsql-hackers
Attachments
- Screenshot_20220113_095249.png (image/png)
13.01.2022 09:36, Thomas Munro wrote: > On Wed, Jan 12, 2022 at 8:00 PM Alexander Lakhin <exclusion@gmail.com> wrote: >> By the look of things, you are right and this is the localhost-only issue. > But can't that be explained with timing races? You change some stuff > around and it becomes less likely that you get a FIN to arrive in a > super narrow window, which I'm guessing looks something like: recv -> > EWOULDBLOCK, [receive FIN], wait -> FD_CLOSE, wait [hangs]. Note that > it's not happening on several Windows BF animals, and the ones it is > happening on only do it only every few weeks. But I still see the issue when I run both test parts on a single machine: first instance is `vcregress taptest src\test\restart` and the second `set NO_TEMP_INSTALL=1 & vcregress taptest contrib/postgres_fdw` (see attachment). I'll try new tests and continue investigation later today/tomorrow. Thanks! Best regards, Alexander
Commits
-
Revert "graceful shutdown" changes for Windows.
- 29992a6a509b 15.0 landed
-
Revert "graceful shutdown" changes for Windows, in back branches only.
- bbb1caf6b220 11.15 landed
- 75674c7ec1b1 14.2 landed
- 64b2c6507e57 12.10 landed
- 645c9457f296 10.20 landed
- 213c5aa3bdba 13.6 landed