Re: Correction of RowMark Removal During Sel-Join Elimination

Andrei Lepikhov <lepihov@gmail.com>

From: Andrei Lepikhov <lepihov@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Richard Guo <guofenglinux@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Greg Sabino Mullane <htamfids@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alexander Lakhin <exclusion@gmail.com>
Date: 2026-01-05T07:08:59Z
Lists: pgsql-hackers
On 4/1/26 09:38, David Rowley wrote:
> On Sun, 31 Aug 2025 at 13:04, Richard Guo <guofenglinux@gmail.com> wrote:
>>
>> On Sun, Aug 31, 2025 at 9:50 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
>>> On Sun, Aug 31, 2025 at 2:51 AM Richard Guo <guofenglinux@gmail.com> wrote:
>>>> I think it's better to push this patch sooner rather than later, as
>>>> multiple people have encountered the issue in different ways.  I'll go
>>>> ahead and push 0001 from my patch set shortly.
>>
>>> I see.  You're much farther than I'm.  Please, go ahead pushing this.
>>
>> Done.
> 
> Is there anything left for this thread now? There's still a CF entry
> [1] for this. Can the status be updated according to the current
> situation? I see the CF entry's tags claim this is a "BugFix" and
> "Refactoring Only". It can't be both of those. If work still needs to
> be done here, can the tags also be fixed?

I checked the thread again, and everything is done.
It looks like the 'bugfix' tag was added by mistake, probably because 
Alexander reported a bug in this thread. Now, the thread covers both 
refactoring and bug fixing ;). You can pick whichever tag fits best, or 
leave it as is to mirror the real state.

-- 
regards, Andrei Lepikhov,
pgEdge



Commits

  1. Improve RowMark handling during Self-Join Elimination

  2. Refactor variable names in remove_self_joins_one_group()

  3. Reduce "Var IS [NOT] NULL" quals during constant folding

  4. Reimplement parsing and storage of default expressions and constraint