Horton

Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Cc: steven.winfield@cantabcapital.com
Date: 2020-01-03T07:54:35Z
Lists: pgsql-bugs, pgsql-hackers 
On 2019-11-03 23:40, Tom Lane wrote:
> * The patch now always quotes completed filenames, so quote_if_needed()
> is misnamed and overcomplicated for this use-case.  I left the extra
> generality in place for possible future use.  On the other hand, this
> is the*only*  use-case, so you could also argue that we should just
> simplify the function's API.  I have no strong opinion about that.

I haven't found an explanation in this thread why it does always quote 
now.  That seems a bit unusual.  Is there a reason for this?  Can we do 
without it?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve psql's tab completion for filenames.

  2. Modernize our readline API a tad.

  3. Add tab completion for EXPLAIN (SETTINGS) in psql