Horton

Re: [PATCH] Add sortsupport for range types and btree_gist

Bernd Helmle <mailings@oopsware.de>

View thread View on postgr.es
From: Bernd Helmle <mailings@oopsware.de>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>, jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-12-09T17:10:53Z
Lists: pgsql-hackers

Attachments

Am Samstag, dem 30.11.2024 um 22:18 +0500 schrieb Andrey Borodin:
> We tried to go that route, random DEBUG1 lines were breaking tests
> (autovacuum or something like that, there was something non-
> deterministic). I think we can dig exact reason from 2021 thread why
> we abandoned that idea...
> 
> I think we have two options:
> 1. Just do not commit tests. We ran it manually, saw that paths are
> taken, we are happy.

So here's a version with the original, unchanged regression tests and
injection point removed (i hope i forgot nothing to revert).

This version also fixes cidr sortsupport (thanks again Andrey for
spotting this), where i accidently used inet instead of the correct
cidr datatype to pass down to the sortsupport function.


Thanks,
	Bernd

Commits

  1. Add support for sorted gist index builds to btree_gist

  2. Add GiST and btree sortsupport routines for range types

  3. Change gist stratnum function to use CompareType

  4. Doc: improve documentation for jsonpath behavior.

  5. Add sortsupport for gist_btree opclasses, for faster index builds.