Re: pg_stat_statements vs. SELECT FOR UPDATE

On 19/01/2019 15:43, Andrew Gierth wrote:
> pg_stat_statements considers a plain select and a select for update to
> be equivalent, which seems quite wrong to me as they will have very
> different performance characteristics due to locking.
> 
> The only comment about it in the code is:
> 
>     /* we ignore rowMarks */
> 
> I propose that it should not ignore rowMarks, per the attached patch or
> something similar.
> 
> (thanks to Vik Fearing for preliminary testing)

I don't this needs any documentation changes, but some tests would be
nice.  I will go add some.  Does the extension need a version bump for this?
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support