Horton

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

Laurenz Albe <laurenz.albe@cybertec.at>

View thread View on postgr.es
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Nathan Bossart <nathandbossart@gmail.com>, Stephen Frost <sfrost@snowman.net>
Cc: David Steele <david@pgmasters.net>, Chapman Flack <chap@anastigmatix.net>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@lists.postgresql.org
Date: 2022-04-06T10:59:18Z
Lists: pgsql-hackers 
On Tue, 2022-04-05 at 13:06 -0700, Nathan Bossart wrote:
> On Tue, Apr 05, 2022 at 11:25:36AM -0400, Stephen Frost wrote:
> > Please find attached an updated patch + commit message.  Mostly, I just
> > went through and did a bit more in terms of updating the documentation
> > and improving the comments (there were some places that were still
> > worrying about the chance of a 'stray' backup_label file existing, which
> > isn't possible any longer), along with some additional testing and
> > review.  This is looking pretty good to me, but other thoughts are
> > certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.
> 
> LGTM!

Cassandra (not the software) from the sidelines predicts that we will
get some fire from users for this, although I concede the theoretical
sanity of the change.

Yours,
Laurenz Albe

Commits

  1. Remove duplicated word in comment of basebackup.c