Re: lippq client library and openssl initialization: PQinitOpenSSL()
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sebastien Flaesch <sebastien.flaesch@4js.com>,
"pgsql-general@lists.postgresql.org" <pgsql-general@lists.postgresql.org>
Date: 2022-09-12T11:21:57Z
Lists: pgsql-general
On 11.09.22 23:43, Daniel Gustafsson wrote: >> On 11 Sep 2022, at 23:35, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> >> Daniel Gustafsson <daniel@yesql.se> writes: >>> On 11 Sep 2022, at 17:08, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>>> Don't believe so. The HAVE_CRYPTO_LOCK stuff is all obsolete and >>>> not compiled if you built against 1.1.0. The only thing left that >>>> will happen if you don't call PQinitOpenSSL is an extra call to >>>> OPENSSL_init_ssl, which should be harmless as far as I can see >>>> from the OpenSSL docs. >> >>> To the best of my knowledge, thats entirely correct. >> >> Should we document these functions as obsolete when using >> OpenSSL >= 1.1.0 ? > > Given that 1.1.0+ is very common, it's probably not a bad idea to document them > as obsolete but harmless. Unless you beat me to it I can propose a patch. AFAICT, RHEL 7 ships with an older version. I think that's still pretty widespread.
Commits
-
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+
- ea7894d33d17 11.20 landed
- e76fbcf796d6 12.15 landed
- 36f49be80856 13.11 landed
- e9884e992186 14.8 landed
- de575c78e14c 15.3 landed
- 928e05ddfd40 16.0 landed