Re: SQL/JSON revisited

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Amit Langote <amitlangote09@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, e.indrupskaya@postgrespro.ru

Date: 2023-03-17T01:14:35Z

Lists: pgsql-hackers

Attachments

v10-0001-SQL-JSON-constructors.patch (text/x-patch) patch v10-0001
v10-0002-reduce-number-of-new-grammar-non-terminal-symbols.patch (text/x-patch) patch v10-0002
v10-0003-IS-JSON-predicate.patch (text/x-patch) patch v10-0003
v10-0004-SQL-JSON-query-functions.patch (text/x-patch) patch v10-0004
v10-0005-remove-more-non-terminal-grammar-symbols.patch (text/x-patch) patch v10-0005
v10-0006-SQL-JSON-functions.patch (text/x-patch) patch v10-0006
v10-0007-RETURNING-clause-for-JSON-and-JSON_SCALAR.patch (text/x-patch) patch v10-0007
v10-0008-JSON_TABLE.patch (text/x-patch) patch v10-0008
v10-0009-Claim-SQL-standard-compliance-for-SQL-JSON-features.patch (text/x-patch) patch v10-0009

On 2023-03-15 We 08:49, Amit Langote wrote:
> Hi,
>
> On Thu, Mar 9, 2023 at 10:08 PM Peter Eisentraut
> <peter.eisentraut@enterprisedb.com>  wrote:
>> On 08.03.23 22:40, Andrew Dunstan wrote:
>>> These both seem like things not worth holding up progress for, and I
>>> think it would be good to get these patches committed as soon as
>>> possible. My intention is to commit them (after some grammar
>>> adjustments) plus their documentation in the next few days.
>> If possible, the documentation for each incremental part should be part
>> of that patch, not a separate all-in-one patch.
> Here's a version that includes documentation of the individual bits in
> their own commits.  I've also merged the patch to add the PLAN clause
> to JSON_TABLE into the patch that adds JSON_TABLE itself.

Hi, I have taken these and done some surgery to reduce the explosion on 
grammar symbols. The attached set is just Amit's patches with some of 
this surgery done - nothing other than gram.y has been touched. Patches 
2 and 5 in the series could be sanely squashed onto patches 1 and 4 
respectively. I haven't done anything significant yet with the JSONTABLE 
patch, there is probably some more low hanging fruit there, and possibly 
some still in the earlier patches.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Add SQL/JSON query functions
- 6185c9737cf4 17.0 landed
Add soft error handling to some expression nodes
- aaaf9449ec6b 17.0 landed
Adjust populate_record_field() to handle errors softly
- 1edb3b491bee 17.0 landed
Refactor code used by jsonpath executor to fetch variables
- faa2b953ba3b 17.0 landed
Code review for recent SQL/JSON commits
- 71bfd1543f8b 16.0 landed
Fix inconsistencies and style issues in new SQL/JSON code
- 60966f56c3e4 16.0 landed
Don't install postmaster symlink anymore
- 37e267335068 16.0 cited
Revert SQL/JSON features
- 2f2b18bd3f55 16.0 cited
Doc: standardize markup a bit more.
- 47046763c3ed 13.0 cited