Re: Record queryid when auto_explain.log_verbose is on

torikoshia <torikoshia@oss.nttdata.com>

From: torikoshia <torikoshia@oss.nttdata.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Michael Paquier <michael@paquier.xyz>, Julien Rouhaud <rjuju123@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: 2023-03-07T02:18:29Z
Lists: pgsql-hackers
On 2023-03-07 08:50, Imseih (AWS), Sami wrote:
> I am wondering if this patch should be backpatched?
> 
> The reason being is in auto_explain documentation [1],
> there is a claim of equivalence of the auto_explain.log_verbose
> option and EXPLAIN(verbose)
> 
> "..... it's equivalent to the VERBOSE option of EXPLAIN."
> 
> This can be quite confusing for users of the extension.
> The documentation should either be updated or a backpatch
> all the way down to 14, which the version the query identifier
> was moved to core. I am in favor of the latter.
> 
> Any thoughts?

We discussed a bit whether to backpatch this, but agreed that it would 
be better not to do so for the following reasons:

> It's a bit annoying that the info is missing since pg 14, but we 
> probably can't
> backpatch this as it might break log parser tools.

What do you think?

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION



Commits

  1. Make auto_explain print the query identifier in verbose mode