Horton

Re: Generate pg_stat_get_* functions with Macros

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-12-10T08:06:06Z
Lists: pgsql-hackers 
Hi,

On 12/10/22 4:55 AM, Nathan Bossart wrote:
> On Fri, Dec 09, 2022 at 09:43:56PM -0500, Tom Lane wrote:
>> Presumably it could be silenced by removing the semicolons after
>> the new macro calls:
> 
>> The backslash after the last right brace means that the line
>> following that is part of the macro body.  This does no harm as
>> long as said line is blank ... but I think it's a foot-gun
>> waiting to bite somebody, because visually you'd think the macro
>> ends with the brace.  So I'd leave off that last backslash.
> 
> Indeed.  Patch attached.
> 

Oh right. Thanks Tom for the explanations and Nathan/Michael for the fix.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix macro definitions in pgstatfuncs.c

  2. Generate pg_stat_get*() functions for databases using macros