Re: Crash when partition column specified twice

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Robert Haas <robertmhaas@gmail.com>, Beena Emerson <memissemerson@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-01T00:13:36Z
Lists: pgsql-hackers
On 2017/04/29 2:53, Robert Haas wrote:
> On Fri, Apr 28, 2017 at 7:23 AM, Beena Emerson <memissemerson@gmail.com> wrote:
>> Hello Amit,
>>
>> The extra n->is_from_type = false; seems to be added by mistake?
>>
>> @@ -11888,6 +11891,8 @@ TableFuncElement:   ColId Typename
>> opt_collate_clause
>>                     n->is_local = true;
>>                     n->is_not_null = false;
>>                     n->is_from_type = false;
>> +                   n->is_from_type = false;
>> +                   n->is_from_parent = false;
>>                     n->storage = 0;
>>                     n->raw_default = NULL;
>>                     n->cooked_default = NULL;
> 
> Good catch.  Committed after fixing that issue.

Thanks both.

Regards,
Amit



Commits

  1. Fix crash when partitioned column specified twice.