Re: pure parsers and reentrant scanners

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>

To: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-12-18T18:44:47Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Return yyparse() result not via global variable
- 473a575e0597 18.0 landed
Remove flex version checks
- 0869ea43e9c2 18.0 landed
Drop warning-free support for Flex 2.5.35
- 6fdd5d956343 18.0 landed
plpgsql: pure parser and reentrant scanner
- 7b27f5fd36cb 18.0 landed
flex code modernization: Replace YY_EXTRA_TYPE define with flex option
- b1ef48980ddd 18.0 landed
guc: reentrant scanner
- d663f150b5ed 18.0 landed
jsonpath scanner: reentrant scanner
- 2a7425d7eef9 18.0 landed
syncrep parser: pure parser and reentrant scanner
- db6856c9913f 18.0 landed
replication parser: pure parser and reentrant scanner
- e4a8fb8fefb9 18.0 landed
bootstrap: pure parser and reentrant scanner
- 3e4bacb17100 18.0 landed
Small whitespace improvement
- 399d0f1e11b5 18.0 landed
Prevent redeclaration of typedef yyscan_t
- 382092a0cd2c 18.0 landed
seg: pure parser and reentrant scanner
- 1f0de66ea2a5 18.0 landed
cube: pure parser and reentrant scanner
- 802fe923e3cd 18.0 landed

On 12/18/24 10:42 AM, Peter Eisentraut wrote:
> I can fix that with the attached patch.
> 
> The symbol YY_TYPEDEF_YY_SCANNER_T isn't documented, but we already use 
> it elsewhere in the code.
> 
> Note that in replication/syncrep.h and replication/walsender_private.h 
> we have to have an #ifndef wrapper because there are files that end up 
> including both headers.  Maybe we should put that #ifndef wrapper 
> everywhere for consistency?
> 
> Any thoughts?

Seems like a sane fix to me and as for the ifndef I have no strong 
opinion either way but I would personally probably have added it 
everywhere for consistency.

Andreas