Re: Error-like LOG when connecting with SSL for password authentication
Heikki Linnakangas <hlinnaka@iki.fi>
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>,
Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-05-23T10:36:02Z
Lists: pgsql-hackers
On 05/22/2017 10:11 PM, Vaishnavi Prabakaran wrote: > On Mon, May 22, 2017 at 5:10 PM, Michael Paquier <michael.paquier@gmail.com> > wrote: > >> If the protocol version is SSL >> 3.0 or TLS 1.0, this result code is returned only if a closure alert >> has occurred in the protocol, i.e. if the connection has been closed >> cleanly. Note that in this case SSL_ERROR_ZERO_RETURN does not >> necessarily indicate that the underlying transport has been closed. > > I guess this error code exist even for SSL2 protocol, In that case, don't > we need to keep the current code for this error code? If I understand correctly, with SSLv2, SSL_ERROR_ZERO_RETURN does mean that the underlying transport has been closed. Returning 0 seems appropriate in that case, too. But the point is moot anyway, because PostgreSQL doesn't allow SSLv2 anymore. - Heikki
Commits
-
Treat clean shutdown of an SSL connection same as the non-SSL case.
- fb1110085b47 9.2.22 landed
- 543e00bc1f06 9.3.18 landed
- fb63a0aa3388 9.4.13 landed
- 90630a6ad187 9.5.8 landed
- f73382877e3e 9.6.4 landed
- b93827c745f3 10.0 landed