Re: Increase value of OUTER_VAR
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Andrey Lepikhov <a.lepikhov@postgrespro.ru>,
Julien Rouhaud <rjuju123@gmail.com>, Amit Langote <amitlangote09@gmail.com>,
David Rowley <dgrowleyml@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-06T08:43:45Z
Lists: pgsql-hackers
On 04.03.21 20:01, Tom Lane wrote: > Just as a proof of concept, I tried the attached, and it passes > check-world. So if there's anyplace trying to stuff OUTER_VAR and > friends into bitmapsets, it's pretty far off the beaten track. > > The main loose ends that'd have to be settled seem to be: > > (1) What data type do we want Var.varno to be declared as? In the > previous thread, Robert opined that plain "int" isn't a good choice, > but I'm not sure I agree. There's enough "int" for rangetable indexes > all over the place that it'd be a fool's errand to try to make it > uniformly something different. int seems fine. > (2) Does that datatype change need to propagate anywhere besides > what I touched here? I did not make any effort to search for > other places. I think Var.varnosyn CurrentOfExpr.cvarno should also have their type changed.
Commits
-
Remove arbitrary 64K-or-so limit on rangetable size.
- e3ec3c00d85b 15.0 landed
-
More cleanups of the include files
- 105409746499 7.1.1 cited