Re: Windows v readline
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-01-03T08:06:10Z
Lists: pgsql-hackers
On 2019-12-30 14:28, Tom Lane wrote: > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: >> On 2019-09-29 22:55, Andrew Dunstan wrote: >>> It would certainly be nice to have readline-enabled psql on Windows if >>> possible. > >> I tried this out. First, it doesn't build, because readline doesn't do >> the dllimport/dllexport dance on global variables, so all references to >> rl_* global variables in tab-complete.c fail (similar to [0]). After >> patching those out, it builds, but it doesn't work. > > What do you mean by "patching those out" --- you removed all of > tab-complete's external variable assignments? That would certainly > disable tab completion, at a minimum. Yeah, basically remove tab completion altogether. But readline would still be useful without that for line editing and history. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Add work-around for VA_ARGS_NARGS() on MSVC.
- 3f28bd7337d7 16.0 landed