Thread

Re: [PATCH] Two small errhint cleanups in PG19 code

Chao Li <li.evan.chao@gmail.com> — 2026-05-25T05:38:26Z

> On May 25, 2026, at 10:38, Baji Shaik <baji.pgdev@gmail.com> wrote:
> 
> Hi,
> 
> While exploring new features in PG19, I came across two unrelated
> small errhint issues. Sending them as separate patches in one thread since they touch
> unrelated subsystems and can be reviewed/committed independently.
> 
> Patch 0001 -- Remove stray word in pg_restore_extended_stats() errhint
> The errhint in import_pg_statistic() reads:
> 
>       Value of element "%s" must be type a null or a string.
> 
>   The word "type" is a stray word that doesn't belong; the intent is
>   "must be a null or a string".

Agreed.

> 
> Patch 0002 -- Add missing period to online data checksums errhint
>   The errhint emitted when StartupXLOG() detects an interrupted
>   "enabling data checksums" run is missing a trailing period:
> 
>       Data checksum processing must be manually restarted for
>       checksums to be enabled
> 

Yes, a hint message should end with a period.

> Thanks,
> Baji Shaik
> <0002-Add-missing-period-to-online-data-checksums-errhint.patch><0001-Remove-stray-word-in-pg_restore_extended_stats-errhi.patch>


So, both changes look good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/