Thread

Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

David E. Wheeler <david@justatheory.com> — 2025-07-10T22:40:43Z

On Jul 10, 2025, at 14:13, David E. Wheeler <david@justatheory.com> wrote:

> Oh, is that what’s happening? What needs to happen to properly support pg_upgrade?

Turns out there was an assertion failure that David Johnson spotted in the core dump of the test output and then in the regress log. Turns out I wasn’t using `--enable-assert` in my testing. With that I was able to replicate it and find the core dump in the “Crash Reports” tab of the macOS Console.app with this line:

{"imageOffset":8079100,"sourceLine":1265,"sourceFile":"jsonpath.c","symbol":"jspGetLeftArg","imageIndex":0,"symbolLocation":348},

When I switched to using jspGetLeftArg and jspGetRightArg in the last patch, I forgot to add the assertions you originally had in your patch, Florents. Resolved in the attached, which now passes `make check-world` for me.

Also available as a pull request[1].

Best,

David

[1] https://github.com/theory/postgres/pull/12/files