Re: Proposal for Allow postgresql.conf values to be changed via SQL
Amit Kapila <amit.kapila@huawei.com>
From: Amit kapila <amit.kapila@huawei.com>
To: "'Tom Lane'" <tgl@sss.pgh.pa.us>, "'Robert Haas'" <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2012-12-10T12:58:42Z
Lists: pgsql-hackers
Attachments
- set_persistent_v3.patch (application/octet-stream) patch v3
On Thu, 6 Dec 2012 10:12:31 +0530 Amit Kapila wrote: On Tuesday, December 04, 2012 8:37 AM Amit Kapila wrote: > On Monday, December 03, 2012 8:59 PM Tom Lane wrote: > > Robert Haas <robertmhaas(at)gmail(dot)com> writes: > > > On Sat, Dec 1, 2012 at 11:45 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote: >> > Neither of you have responded to the point about what "SET PERSISTENT >> > var_name TO DEFAULT" will do, and whether it is or should be different >> > from RESET PERSISTENT, and if not why we should put the latter into >> > the grammar as well. > > >> The current behavior is >> 1. "RESET PERSISTENT ..." will delete the entry from >> postgresql.auto.conf >> 2. "SET PERSISTENT... TO DEFAULT" will update the entry value in >> postgresql.auto.conf to default value > >> However we can even change "SET PERSISTENT... TO DEFAULT" to delete the >> entry and then we can avoid "RESET PERSISTENT ..." > As per my understanding from the points raised by you, the behavior could be > defined as follows: > 1. No need to have "RESET PERSISTENT ..." syntax. > 2. It is better if we provide a way to delete entry which could be done for > syntax: > "SET PERSISTENT... TO DEFAULT" Updated patch to handle above 2 points. With Regards, Amit Kapila.