Re: Review: Patch to compute Max LSN of Data Pages

Amit Kapila <amit.kapila@huawei.com>

From: Amit kapila <amit.kapila@huawei.com>

To: Tom Lane <tgl@sss.pgh.pa.us>, "'Muhammad Usama'" <m.usama@gmail.com>

Cc: Muhammad Usama <m.usama@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2012-12-09T05:30:02Z

Lists: pgsql-hackers

Attachments

pg_computemaxlsn_v4.patch (application/octet-stream) patch v4

On Saturday, December 08, 2012 9:44 AM Tom Lane wrote:
Amit kapila <amit.kapila@huawei.com> writes:
> On Friday, December 07, 2012 7:43 PM Muhammad Usama wrote:
>>> Although I am thinking why are you disallowing the absolute path of file. Any particular reason?

>> The reason to disallow absolute path is that, we need to test on multiple platforms and to keep the scope little less.

>This argument seems to me to be completely nuts.  What's wrong with an
>absolute path?  Wouldn't you have to go out of your way to disallow it?

There's nothing wrong with absolute path. I have updated the patch to work for absolute path as well.
Updated patch attached with this mail.


With Regards,
Amit Kapila.