Re: external_pid_file not removed on postmaster exit

Amit Kapila <amit.kapila@huawei.com>

From: Amit kapila <amit.kapila@huawei.com>
To: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-28T07:41:49Z
Lists: pgsql-hackers
>From: pgsql-hackers-owner@postgresql.org [pgsql-hackers-owner@postgresql.org] on behalf of Peter Eisentraut [peter_e@gmx.net]
> Sent: Friday, July 27, 2012 10:39 AM

> It seems strange that the external_pid_file is never removed.  There is
> even a C comment about it:

> /* Should we remove the pid file on postmaster exit? */

> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.

external_pid_file is created first time when it is enabled in postgresql.conf
I think it should be removed once the parameter external_pid_file is unset; 

Making handling of both postmaster.pid and external_pid_file same in terms of creation and removal may not be best choice
as both have different purpose.



With Regards,
Amit Kapila.