Re: [PATCH] Patch to compute Max LSN of Data Pages

Amit Kapila <amit.kapila@huawei.com>

From: Amit kapila <amit.kapila@huawei.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Fujii Masao <masao.fujii@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2012-11-16T11:22:14Z

Lists: pgsql-hackers

Attachments

pg_computemaxlsn.patch (application/octet-stream) patch
Test_find_max_lsn_from_datafiles.txt (text/plain)

On Thursday, November 15, 2012 7:30 PM Robert Haas wrote:
On Thu, Nov 15, 2012 at 12:08 AM, Amit Kapila <amit.kapila@huawei.com> wrote:
>> Okay.
>> So as Robert and Alvaro suggested to have it separate utility rather than
>> having options in pg_resetxlog to print MAX LSN seems to be quite
>> appropriate.
>> I am planning to update the patch to make it a separate utility as
>> pg_computemaxlsn with options same as what I have proposed for pg_resetxlog
>> to print MAX LSN.
>> So considering it a separate utility there can be 2 options:
>> a. have a utility in contrib.
>> b. have a utility in bin similar to pg_resetxlog

> I guess I'd vote for contrib, but I wouldn't be crushed if it went the
> other way.

Updated test cases and patch to have separate utility in contrib for pg_computemaxlsn are attached with this mail.

With Regards,
Amit Kapila.